Added multi-language support #153
Conversation
|
Hey @troskop - this looks really good! I'll try to merge this in later - however, we'll have to thoroughly test it. Have you tested it much yet? |
|
I tested it using different browsers (Chromium, Firefox; both running on ubuntu 15.04). PS: This script has one small by-effect. The user has to download some files more (the language-files and the "LanguageServer.js"). I hope it will work. |
|
@garrettdreyfus and I will start testing it as well! That's fine, language files are probably pretty small, right? |
|
The german file is for example just 3.48 KB large. This is nothing today. Every ad on webpages is larger :D |
|
Yep that's no big deal! 👍 On Wed, Oct 7, 2015 at 1:53 AM, Thomas Roskop notifications@github.com
|
|
Could you please inform me when you've decided about this request? |
|
I would like to merge in this pull request but I have to review it to make On Wed, Oct 7, 2015 at 2:10 PM, Thomas Roskop notifications@github.com
|
|
And, have you decided yet? |
|
@troskop I have midterms right now at my university - sorry for the delay. I think @garrettdreyfus has started looking at integration though - we should be ready soon (within the next month). |
|
Hi! |
|
Hello, |
|
I can also translate the app in french, multi language support is important for us ^^ |
|
Hi @troskop! I'd be happy to take a look at this request. Unfortunately, I think something went wrong with this PR because you deleted the fork. Would you be able to submit another PR with these changes? |
Hello,
I really enjoy the "hextris"-game.
But it is to bad that it only worked in english. So i coded something to allow this game to support more then one language. As an example I also added support for the german language (de-DE).
Hope this helps you app. If you have questions etc. feel free to ask!